igvm_defs, igvm: introduce semantic versioning header#128
Draft
SethHollandsworth wants to merge 1 commit into
Draft
igvm_defs, igvm: introduce semantic versioning header#128SethHollandsworth wants to merge 1 commit into
SethHollandsworth wants to merge 1 commit into
Conversation
SethHollandsworth
marked this pull request as draft
July 16, 2026 16:00
Contributor
|
I think we also want a serializer API to set the version. |
SethHollandsworth
force-pushed
the
sethho/igvm_version_header
branch
from
July 22, 2026 17:25
913255b to
df82988
Compare
Author
Added the serializer @mingweishih |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for an IGVM file version header, allowing the version of the file contents to be described using a
major.minor.patchtriple. At most one version header is allowed per file, and merge logic ensures that versions match.IGVM Version Header Support
IGVM_VHS_IGVM_VERSIONstruct and corresponding header typeIGVM_VHT_IGVM_VERSIONto represent the file version (major.minor.patch). This header is only allowed once per file and must be 8-byte aligned.IgvmInitializationHeaderand related logic to support parsing, serializing, and validating the new version header, including ensuring that only one is present and that the reserved field is zero.File Merge Logic
IgvmFile::mergeto ensure that if both files have a version header, they must match exactly; otherwise, merging fails with a new error. Only one version header is retained in the merged file.Error Handling
MultipleIgvmVersionsfor multiple version headers in one file, andMergeIgvmVersionMismatchfor mismatched versions during merge.Testing
These changes ensure IGVM files can explicitly declare their version, and that this information is consistently enforced and preserved during file operations.